🌱 Add flag to reserve memory to the virtual machine memory size #2469

maximsnezhkov · 2023-10-29T08:32:12Z

What this PR does / why we need it:
Add flag to configure memory reservation at VSphereMachineTemplate level.
Which issue(s) this PR fixes:
Fixes #2468

linux-foundation-easycla · 2023-10-29T08:32:16Z

The committers listed above are authorized under a signed CLA.

✅ login: maximsnezhkov / name: Maxim Snezhkov (9cec761)

k8s-ci-robot · 2023-10-29T08:32:20Z

Welcome @maximsnezhkov!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-10-29T08:32:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-10-29T08:32:21Z

Hi @maximsnezhkov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon

/ok-to-test

killianmuldoon · 2023-10-30T10:05:46Z

Thanks for the contribution @maximsnezhkov - it would be great to add this to an e2e test so we can ensure it works as expected. Do we know if there's limitations on which environments or versions of VSphere this is available on?

codecov · 2023-10-30T10:11:52Z

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.50%. Comparing base (a4eef1b) to head (9cec761).
Report is 580 commits behind head on main.

Files	Patch %	Lines
pkg/services/govmomi/vcenter/clone.go	71.42%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2469      +/-   ##
==========================================
- Coverage   63.63%   63.50%   -0.14%     
==========================================
  Files         122      122              
  Lines        8753     8759       +6     
==========================================
- Hits         5570     5562       -8     
- Misses       2773     2783      +10     
- Partials      410      414       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maximsnezhkov · 2023-10-31T17:38:57Z

Thanks for the contribution @maximsnezhkov - it would be great to add this to an e2e test so we can ensure it works as expected. Do we know if there's limitations on which environments or versions of VSphere this is available on?

You're welcome. As I understand it, this functionality has been available for use since at least 2013 (https://frankdenneman.nl/2013/02/21/reserve-all-guest-memory-all-locked/)

pkg/services/govmomi/vcenter/clone.go

chrischdi · 2023-11-20T12:37:16Z

/retest

chrischdi · 2024-02-29T08:27:40Z

/retest

chrischdi · 2024-02-29T08:33:30Z

pkg/services/govmomi/vcenter/clone.go

+			NumCPUs:                      numCPUs,
+			NumCoresPerSocket:            numCoresPerSocket,
+			MemoryMB:                     memMiB,
+			MemoryReservationLockedToMax: memLockedToMax,


Suggested change

MemoryReservationLockedToMax: memLockedToMax,

MemoryReservationLockedToMax: vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax,

We can directly reference that setting.

chrischdi · 2024-02-29T08:34:05Z

pkg/services/govmomi/vcenter/clone.go

+	var memLockedToMax *bool
+	if vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax != nil {
+		memLockedToMax = new(bool)
+		*memLockedToMax = *vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax
+	}
+


Suggested change

var memLockedToMax *bool

if vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax != nil {

memLockedToMax = new(bool)

*memLockedToMax = *vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax

}

Should not be required when directly referring below

sbueringer · 2024-04-09T12:45:44Z

@maximsnezhkov Are you still interested in pursuing this PR? (and do you have time to adress the open comments)

sbueringer · 2024-07-10T04:32:08Z

/close

See above

k8s-ci-robot · 2024-07-10T04:32:12Z

@sbueringer: Closed this PR.

In response to this:

/close

See above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 29, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 29, 2023

k8s-ci-robot requested review from vrabbi and yastij October 29, 2023 08:32

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2023

Add flag to reserve memory to the virtual machine memory size

9cec761

maximsnezhkov force-pushed the allow-memory-reservation-to-max branch from 1a65208 to 9cec761 Compare October 29, 2023 08:37

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 29, 2023

killianmuldoon reviewed Oct 30, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2023

chrischdi reviewed Nov 20, 2023

View reviewed changes

pkg/services/govmomi/vcenter/clone.go Show resolved Hide resolved

chrischdi reviewed Feb 29, 2024

View reviewed changes

k8s-ci-robot closed this Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 Add flag to reserve memory to the virtual machine memory size #2469

🌱 Add flag to reserve memory to the virtual machine memory size #2469

maximsnezhkov commented Oct 29, 2023 •

edited

Loading

linux-foundation-easycla bot commented Oct 29, 2023 •

edited

Loading

k8s-ci-robot commented Oct 29, 2023

k8s-ci-robot commented Oct 29, 2023

k8s-ci-robot commented Oct 29, 2023

killianmuldoon left a comment

killianmuldoon commented Oct 30, 2023

codecov bot commented Oct 30, 2023 •

edited

Loading

maximsnezhkov commented Oct 31, 2023

chrischdi commented Nov 20, 2023

chrischdi commented Feb 29, 2024

chrischdi Feb 29, 2024

chrischdi Feb 29, 2024

sbueringer commented Apr 9, 2024 •

edited

Loading

sbueringer commented Jul 10, 2024

k8s-ci-robot commented Jul 10, 2024

	MemoryReservationLockedToMax: memLockedToMax,
	MemoryReservationLockedToMax: vmCtx.VSphereVM.Spec.MemoryReservationLockedToMax,

🌱 Add flag to reserve memory to the virtual machine memory size #2469

🌱 Add flag to reserve memory to the virtual machine memory size #2469

Conversation

maximsnezhkov commented Oct 29, 2023 • edited Loading

linux-foundation-easycla bot commented Oct 29, 2023 • edited Loading

k8s-ci-robot commented Oct 29, 2023

k8s-ci-robot commented Oct 29, 2023

k8s-ci-robot commented Oct 29, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

killianmuldoon commented Oct 30, 2023

codecov bot commented Oct 30, 2023 • edited Loading

Codecov Report

maximsnezhkov commented Oct 31, 2023

chrischdi commented Nov 20, 2023

chrischdi commented Feb 29, 2024

chrischdi Feb 29, 2024

Choose a reason for hiding this comment

chrischdi Feb 29, 2024

Choose a reason for hiding this comment

sbueringer commented Apr 9, 2024 • edited Loading

sbueringer commented Jul 10, 2024

k8s-ci-robot commented Jul 10, 2024

maximsnezhkov commented Oct 29, 2023 •

edited

Loading

linux-foundation-easycla bot commented Oct 29, 2023 •

edited

Loading

codecov bot commented Oct 30, 2023 •

edited

Loading

sbueringer commented Apr 9, 2024 •

edited

Loading